-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update casing of "JabRef" #10345
Update casing of "JabRef" #10345
Conversation
- Lowercase "jabref" in scripts and binary names - Change vendor to JabRef e.V. - Case "mac-package-identifier" to "JabRef" - Group macos steps together
Maybe, this conflicts with #10340 ( |
The build of this PR is available at https://builds.jabref.org/pull/10345/merge. |
--mac-package-identifier Jabref \ | ||
--mac-package-name JabRef \ | ||
--mac-package-identifier JabRef \ | ||
--mac-package-name "JabRef e.V." \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should go to vendor?
.github/workflows/deployment.yml
Outdated
@@ -283,26 +283,26 @@ jobs: | |||
if: steps.checksecrets.outputs.secretspresent == 'YES' | |||
id: gitversion | |||
uses: gittools/actions/gitversion/execute@v0.10.2 | |||
- name: Get macOS binaries | |||
- name: Get macos binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong! The casing of macOS is correct official
We should discuss implications first |
We should distinguish
#FutureWork |
Follow-up to #10338.
We either need this fix - or add an explanation in the documentation how to "properly" check out the code to have IntelliJ working (one commit in #10322 does this).
Since I more want to have the guideline "intuitive", I would like to have this change in.
The installer file names and the startup scripts will be all-lowercase now. Which I kind of like. (
bin/jabref
instead ofbin/JabRef
)Update casing of "JabRef"
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)